-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDS-96147-Monitored-Service-Template-as-Runtime-Input #6691
Conversation
Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66433f49db4e1a009034fb26--harness-developer.netlify.app |
Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664343fcbac91c03c7a58c96--harness-developer.netlify.app |
Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664377f1bac91c3b7ba58c7e--harness-developer.netlify.app |
Approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review To be continued
Co-authored-by: SushrutHarness <155578943+SushrutHarness@users.noreply.github.com>
Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d6d78062fad8980b5dcc3--harness-developer.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments otherwise LGTM!
|
||
It also allows, user to specify whether it wants to use the “default” or “template” option for the monitored service. What it means is that a monitored service template can be used as part of concrete verify step and also with verify step template. If the purpose is to standardize the step configuration then create a step template for verify step. | ||
:::important | ||
This feature is currently behind the feature flag, `CV_MONITORED_SERVICE_TEMPLATIZATION`. To enable a feature flag in your Harness account, contact [Harness Support](mailto:support@harness.io). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is specifically the ability to select a template during runtime behind this flag? Should we be more specific what part of templatization is behind a future flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Co-authored-by: SushrutHarness <155578943+SushrutHarness@users.noreply.github.com>
Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664d94b5634e2ba05c7b1297--harness-developer.netlify.app |
Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
https://harness.atlassian.net/browse/CDS-96147