Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/harelba/q#301 #304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Sparkx120
Copy link

Fix for #301

This fixes the issue where you cannot install from setup.py by setting the package explicitly.

@kim-fehl
Copy link

I confirm that this patch is working, tested on Python: 3.9.14 and Debian 11

@InCogNiTo124
Copy link
Contributor

@harelba could you please look at this and merge it?

@harelba
Copy link
Owner

harelba commented Jan 15, 2023

Sorry i missed this PR. Thanks!

I need to make sure that build and packaging is not reliant on the hardcoded bin/ path, and then I'll merge it.

@raylu
Copy link

raylu commented Sep 7, 2023

I was actually about to submit a PR for

diff --git a/setup.py b/setup.py
index 6d0fac7..11c07f8 100644
--- a/setup.py
+++ b/setup.py
@@ -22,10 +22,10 @@ setup(
         'six==1.11.0'
     ],
     package_dir={"": "bin"},
-    packages=setuptools.find_packages(where="bin"),
+    py_modules=['q'],
     entry_points={
         'console_scripts': [
-            'q = bin.q:run_standalone'
+            'q = q:run_standalone'
         ]
     }
 )

before I saw this. it's worth noting that

$ python3 -c 'import setuptools; print(setuptools.find_packages(where="bin"))'
[]

the existing packaging (deb, rpm, msi) don't actually build the python sdist/wheel (pip3 install build && python3 -m build or python3 setup.py build), so this doesn't affect existing packaging (also, this setup.py file just doesn't work as is right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants