Gracefully handle errors when binding SocketCAN fails #1771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent class
BusABC
expects to be shutdown properly, checked via itsself._is_shutdown
flag during object deletion. But that flag is only set when the base class'shutdown()
is called, which doesn't happen if instantiation of the concrete class failed incan.Bus()
. So there is no way to avoid the warning message "SocketcanBus was not properly shut down" if the constructor raised an exception.This change addresses that issue for the SocketCAN interface, by catching an OSError exception in
bind_socket()
, logging it, and callingself.shutdown()
before re-raising the exception.There might be a better approach which also works for the other backends? The flag could be initialized to
True
and only reset toFalse
when theBusABC
constructor runs (which happens last in derived classes)?Thus leaving this as a draft for further discussion.