Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add typings from DT #136

Merged
merged 1 commit into from
Jun 9, 2023
Merged

chore: add typings from DT #136

merged 1 commit into from
Jun 9, 2023

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Jun 9, 2023

Straight import from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/hapi__h2o2, I just reformatted the tests to use lab type tests.

Copy link
Member

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Marsup Marsup added this to the 10.0.2 milestone Jun 9, 2023
@Marsup Marsup merged commit 1ba9e6e into master Jun 9, 2023
18 checks passed
@Marsup Marsup deleted the chore/typings branch June 9, 2023 14:19
@Marsup Marsup added the types TypeScript type definitions label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants