Use manual memory management for Nim binary trees #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
force-pushed
the
main
branch
2 times, most recently
from
d24e6bc
to
f81118a
Compare
hanabi1224
force-pushed
the
main
branch
3 times, most recently
from
3fc55d3
to
d70acc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hanabi1224,
I would like to contribute some simple modifications to the 2.nim program to use manual memory management instead of the GC. The new version (3.nim) deallocates each node after it traverses any child nodes, and then deallocates the root nodes at the end of the traversal. It should still fit the description of the binary trees problem from the other benchmarks game.
Let me know if any further modifications are necessary to meet the implementation guidelines. Thanks!