This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt,
I was teaching a friend Rails and using Oath for authentication solution (of course). But I found the multiple fields auth does not work right now. There is already a solution in #55. I update his work so you could merge and release a new version of Oath.
Sign in with multiple fields:
In
authenticate_session
(L103
) we already transformed the paramsoath/lib/oath/controller_helpers.rb
Lines 101 to 107 in f850ea5
and in
Oath.lookup
'sself.config.find_method
oath/lib/oath.rb
Lines 86 to 91 in f850ea5
which calls
Oath::Configuration#default_method
that tries to transform againoath/lib/oath/configuration.rb
Lines 55 to 60 in f850ea5
hence raises this error:
The fix was not transformed twice.
cc @gracewashere Closes #55