[xtensa] Fixed index conversion for gather_load with undefined ramp #8215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aelphy
changed the title
Aelphy
force-pushed
the
feature/gather_load_undefined_ramp
branch
from
1f5e0e1
to
9593fb4
Compare
vksnk
approved these changes
May 8, 2024
vksnk
requested changes
May 8, 2024
src/XtensaOptimize.cpp
Outdated
| if (!op->type.is_vector() || op->index.as<Ramp>()) { | ||
| // If dense_ramp_base is not defined, gather_load will be used and thus, index conversion is needed. | ||
| Expr dense_ramp_base = strided_ramp_base(op->index, 1); | ||
| if (!op->type.is_vector() || !dense_ramp_base.defined()) { |
There was a problem hiding this comment.
I think this shouldn't be negated: if it's a dense ramp then we will use regular load so this transformation is not needed.
There was a problem hiding this comment.
Sorry, forgot to copy back after testing. Done.
Aelphy
force-pushed
the
feature/gather_load_undefined_ramp
branch
from
9593fb4
to
9ad2f7d
Compare
vksnk
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.