Remove unused 'external_buffers' member in Codegen_Xtensa #7466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vksnk
reviewed
Apr 3, 2023
| @@ -786,9 +786,6 @@ void CodeGen_Xtensa::visit(const Load *op) { | |||
| native_lanes = bytes_in_vector / 2; | |||
| } | |||
| bool is_aligned_load = (op->alignment.modulus % native_lanes == 0) && (op->alignment.remainder % native_lanes == 0); | |||
| if (external_buffers.count(op->name) > 0) { | |||
There was a problem hiding this comment.
Ugh, this seems like it was a legit bug. I think if (external_buffers.count(op->name) > 0) should be replaced by if (op->param.defined()) .
There was a problem hiding this comment.
yikes, ok, lets hold off on this PR -- I'll let you choose how to clean this up, you are much closer to this code than I
| @@ -811,7 +808,7 @@ void CodeGen_Xtensa::visit(const Load *op) { | |||
| // } else { | |||
| string id_index = print_expr(op->index); | |||
| // Is not allocated on the heap and is not a buffer | |||
| bool is_tcm = !(heap_allocations.contains(name) || external_buffers.count(op->name) > 0); | |||
|
Did we ever decide if this needed attention? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.