feat: add a cssSelector configuration parameter RevealHighlight #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While in most cases the standard "pre code" selector works fine, there may be instances where the user may want more control on what elements will be affected by the plugin. This solution provides a very easy way to be more selective while being completely non-breaking
TendTo
commented
Jan 28, 2024
| Plugin.highlightBlock( block ); | ||
| } ); | ||
| } | ||
|
|
||
| // If we're printing to PDF, scroll the code highlights of | ||
| // all blocks in the deck into view at once | ||
| reveal.on( 'pdf-ready', function() { | ||
| [].slice.call( reveal.getRevealElement().querySelectorAll( 'pre code[data-line-numbers].current-fragment' ) ).forEach( function( block ) { | ||
| [].slice.call( reveal.getRevealElement().querySelectorAll( config.cssSelector + '[data-line-numbers].current-fragment' ) ).forEach( function( block ) { |
There was a problem hiding this comment.
This line makes sense only for compatible modifications to the selector.
If you wanted to give complete control to the user, a new configuration would need to be added. Something like
config.cssSelectorLineNumbers = typeof config.cssSelectorLineNumbers === 'string' ? config.cssSelectorLineNumbers : 'pre code[data-line-numbers].current-fragment';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is inspired by the highlight.js library'configuration.
While the standard "pre-code" selector works fine in most cases, there may be instances where the user may want more control over what elements the plugin will affect. This solution provides a very easy way to be more selective.
The documentation would need to be updated to account for this new option.