Introduce info string commands #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Have seen briefly, but will look more tomorrow. |
hagenburger
force-pushed
the
info-string-commands
branch
from
30f5542
to
9507e19
Compare
benevbright
requested changes
Sep 18, 2018
lib/config.js
Outdated
| if (infoString === infoStringBefore) { | ||
| const spacePosition = infoString.indexOf(" ") | ||
| if (spacePosition !== -1) { | ||
| const unkown = infoString.substr(0, spacePosition) |
There was a problem hiding this comment.
console.warn's string too.
There was a problem hiding this comment.
@benevbright Thanks! I fixed it.
Merged
Merged
benevbright
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares an API to create #19, #18, and #32. All those features will have very complex regular expressions and escaping. Therefore an API preparing those regular expressions and testing them centrally makes sense.
Every command in info strings consists out of:
+=(optional)regexp,string,number,boolean, ornull; optional)Examples: See #19, #18, and #32