Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme for clarity regarding alpine images #971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itobey
Copy link

@itobey itobey commented Aug 13, 2023

What I did

Update the readme to reflect the fact that the default documented docker run command will not work on an alpine based image of hadolint, as the default path to the config is not working here.

How I did it

Simple update of the readme. I though about fixing this issue in the container image build of hadolint, but that still leaves older versions with the same issue. So you're now aware, the users have a correct readme. Maybe a simple symlink will be enough for future builds.

How to verify it

Run the following commands and you'll see the first one will not have the configuration file loaded as hadolint is looking for environment variables which are not present in the alpine version:
docker run --rm -i -v /path/to/hadolint.yaml:/.config/hadolint.yaml ghcr.io/hadolint/hadolint:2.12.0-alpine hadolint -V
docker run --rm -i -v /path/to/hadolint.yaml:/root/.config/hadolint.yaml ghcr.io/hadolint/hadolint:2.12.0-alpine hadolint -V

@therewillbeblood
Copy link

#652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants