Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release of Darwin arm64 binary #1009

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eread
Copy link

@eread eread commented Mar 27, 2024

@wyuenho
Copy link

wyuenho commented Apr 17, 2024

Can you also add GHC 9.4, 9.6 and 9.8 to the build matrix please? Thanks

@eread
Copy link
Author

eread commented Apr 23, 2024

Can you also add GHC 9.4, 9.6 and 9.8 to the build matrix please? Thanks

Hi @wyuenho. I went ahead and just changed the build to use the latest GHC: 7a09a09, I didn't want to complicate things too much. What do you think?

@eread
Copy link
Author

eread commented Apr 23, 2024

@lorenzo I added a few more commits to this. Could you review? I'm very new with GitHub actions, so am trying to learn as I go.

@eread eread force-pushed the eread/add-release-of-darwin-arm64-binary branch from fb8cb2d to 73f6d61 Compare April 23, 2024 07:01
@wyuenho
Copy link

wyuenho commented Apr 23, 2024

This project is currently being built for Macports and the default GHC there is 9.6, and even GHC on bleeding edge Ubuntu is only at 9.4. I believe there are some dependencies (base? ) that need to be checked if they are compatible with older versions as well.

@lorenzo
Copy link
Member

lorenzo commented Apr 24, 2024

I'll make some time this week to upgrade to latest GHC and merge this branch

@eread eread force-pushed the eread/add-release-of-darwin-arm64-binary branch from 73f6d61 to e14d3d0 Compare April 30, 2024 06:18
@eread
Copy link
Author

eread commented Apr 30, 2024

I'll make some time this week to upgrade to latest GHC and merge this branch

@lorenzo I notice you've added some logic for Apple Silicon builds: d3b3281. Did you want me to close this pull request? There's probably not a lot left to do.

@eread
Copy link
Author

eread commented Apr 30, 2024

This project is currently being built for Macports and the default GHC there is 9.6, and even GHC on bleeding edge Ubuntu is only at 9.4. I believe there are some dependencies (base? ) that need to be checked if they are compatible with older versions as well.

@wyuenho Trying to update even to the latest GHC caused this pull request some problems, so I'll consider it out-of-scope.

There are now some commits on master for this anyway: bf2cb4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants