Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable experimental mode #3585

Merged
merged 8 commits into from May 24, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Apr 8, 2024

Always enable experimental mode, and remove it as a setting from config and option flows

This PR keeps code for legacy mode around, removal of the now dead legacy code will be done in separate PRs.

@MartinHjelmare
Copy link
Contributor

A test needs updating.

@emontnemery emontnemery marked this pull request as draft April 9, 2024 09:52
@emontnemery emontnemery added the Breaking Change Added to pull requests that adds a breaking change label Apr 12, 2024
@emontnemery emontnemery marked this pull request as ready for review May 24, 2024 09:02
@emontnemery
Copy link
Contributor Author

@coderabbitai review

Copy link

coderabbitai bot commented May 24, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

coderabbitai bot commented May 24, 2024

Walkthrough

The changes primarily focus on updating the HacsConfiguration class to set the experimental attribute to True by default and removing references to the experimental setting from configuration flows and translation files. This includes modifying test cases to align with the new default behavior and ensuring that the experimental attribute is not updated from dictionaries. The overall goal is to streamline the handling of experimental features in the HACS component.

Changes

File Path Change Summary
custom_components/hacs/base.py Set experimental attribute to True by default in HacsConfiguration class and skip updating it from dictionaries.
custom_components/hacs/config_flow.py Removed experimental field from validation schemas and configuration form handling logic.
custom_components/hacs/translations/en.json Removed the explanation for enabling experimental features and adjusted custom components acknowledgment.
tests/hacsbase/test_configuration.py Updated assertions for config.experimental and added a new test function for the experimental setting.
tests/snapshots/config_flow/test_full_user_flow_implementation.json Removed experimental option from the options field.
tests/test_config_flow.py Removed "experimental": True key from several dictionaries in async functions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ludeeus
Copy link
Member

ludeeus commented May 24, 2024

@coderabbitai review

Copy link

coderabbitai bot commented May 24, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ludeeus ludeeus merged commit 988b3fe into hacs:main May 24, 2024
22 checks passed
@hacs-bot hacs-bot bot added this to the next milestone May 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change Added to pull requests that adds a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants