Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account, settings, and hacker search #881

Open
wants to merge 9 commits into
base: feat/refactor-to-typescript
Choose a base branch
from

Conversation

jackyyzhang03
Copy link
Member

Tickets:

  • HAC-

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Fix account update, settings, and hacker search

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@jackyyzhang03 jackyyzhang03 changed the title Jacky/refactor Fix account, settings, and hacker search Nov 4, 2022
@jackyyzhang03 jackyyzhang03 changed the base branch from dev to feat/refactor-to-typescript November 5, 2022 18:09
@jackyyzhang03 jackyyzhang03 marked this pull request as ready for review November 11, 2022 19:27
@brarsanmol brarsanmol self-requested a review November 19, 2022 14:42
@brarsanmol brarsanmol self-assigned this Nov 19, 2022
@brarsanmol brarsanmol added the bug Something isn't working label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants