Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return appropriate message on successful authentication login and logout. #761

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

brarsanmol
Copy link
Member

@brarsanmol brarsanmol commented Oct 23, 2021

Summary

The authentication controller documentation is supposed to return a message when login/logout is successful it currently does not do this because of the variable being referred not existing. This PR brings the codebase up to date with the specifications of the documentation (https://docs.mchacks.ca/api/#api-Authentication-login).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@brarsanmol brarsanmol added bug Something isn't working Pri 3 Lowest priority labels Oct 23, 2021
@brarsanmol brarsanmol self-assigned this Oct 23, 2021
@brarsanmol brarsanmol changed the title Fix bug where login and login routes do not return the appropriate su… bug: return appropriate message on successful authentication login and logout. Oct 23, 2021
@brarsanmol brarsanmol changed the title bug: return appropriate message on successful authentication login and logout. fix: return appropriate message on successful authentication login and logout. Oct 23, 2021
Copy link
Member

@logan-r logan-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Pri 3 Lowest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants