Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce pandas pin and update code for numpy 1.24+ #925

Merged
merged 12 commits into from
Mar 26, 2024

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented Feb 8, 2024

This "hypothetical" PR (pending discussion in #915) reintroduces the pandas pin, and re-enables the previously broken tests so that we can safely release the patches for the new pymatgen (that affects lots of users). It also bumps the minimum supported Numpy version following the recommendations of SPEC 0000.

Closes #916.
Closes #923.

@ml-evs ml-evs changed the title [WIP] More dependencies tinkering Reintroduce pandas pin and update tests Feb 9, 2024
@ml-evs
Copy link
Collaborator Author

ml-evs commented Feb 9, 2024

Related to #915.

@ml-evs ml-evs merged commit bb71c0f into main Mar 26, 2024
4 checks passed
@ml-evs ml-evs changed the title Reintroduce pandas pin and update tests Reintroduce pandas pin and update code for numpy 1.24+ Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable tests that are skipped in CI Issue link to matsci.org broken
1 participant