Fixes for CI and tests #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if API key is not provided as an arg to the featurizer, do not pass `None` to `MPRester` as it will then not use the env var.
ml-evs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CI seems to have been broken for a while as
mongoandmongoshdisappeared? supercharge/mongodb-github-action#39 broke when GitHub actions updated the default runner toubuntu-22.04. This PR replaces the use of this third-party action with a GH actions service container.Closes CI failing due to broken mongo service #900.
Also prevents hanging test for atomic packing by setting
n_jobsto 1.Also fixes
MPResterregression for new system where MP API version is chosen dynamically and API key being set toNonedisables read of env varDisables AFLOW tests in CI as they are failing for what seems like non-matminer-related reasons
Fixes test values for
skewnessandkurtosistests, not sure what went wrong here but I don't see how these tests ever passed kurtosis of [1, 1, 1] is undefined, likewise skewness.