Skip to content

Commit

Permalink
Fix maximum element failure (#921)
Browse files Browse the repository at this point in the history
  • Loading branch information
JaGeo committed Feb 6, 2024
1 parent 0332309 commit f810184
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions matminer/utils/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import numpy as np
import pandas as pd
from pymatgen.core.periodic_table import Element, _pt_data
from pymatgen.core.periodic_table import Element

__author__ = "Kiran Mathew, Jiming Chen, Logan Ward, Anubhav Jain, Alex Dunn"

Expand Down Expand Up @@ -206,7 +206,7 @@ def __init__(self):
with open(os.path.join(self.data_dir, f"{descriptor_name}.table")) as f:
self.all_elemental_props[descriptor_name] = dict()
lines = f.readlines()
for atomic_no in range(1, len(_pt_data) + 1): # max Z=103
for atomic_no in range(1, 118 + 1): # (max Z=118)
try:
if descriptor_name in ["OxidationStates"]:
prop_value = [float(i) for i in lines[atomic_no - 1].split()]
Expand Down

0 comments on commit f810184

Please sign in to comment.