This repository has been archived by the owner on Oct 9, 2020. It is now read-only.
Add HomeView + Navbar #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousefa00
reviewed
Sep 29, 2020
client/src/pages/HomeView/styles.css
Outdated
| } | ||
|
|
||
| .title { | ||
| padding-top: 100px; |
There was a problem hiding this comment.
We want to use rem or % rather than px where possible to accommodate for different display sizes.
There was a problem hiding this comment.
Navbar is fixed height – so accounting for that by padding. (Honestly, will probably define a layout component in the future that accounts for that and is applied to all the pages)
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hack4impact/closegap/hc86odt5a |
…closegap into ec/add-nav-bar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: 🚧
Description
• add Home page to the app (has pink background and "Welcome" text)
• add Navbar component to the app
• Navbar with Closegap logo and login/logout buttons (based on current Closegap teacher view)
• add Head component that renders the Navbar component
Todos
Screenshots