Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #121

Closed
wants to merge 1 commit into from
Closed

Update README.md #121

wants to merge 1 commit into from

Conversation

devarsh10
Copy link

Hey @mturoci,
Are the changes expected?
Please let me know if changes are required.

Description:
The guide to run the dockerised app on Windows using cmd is added.

@devarsh10
Update README.md
dc33fbb 
Hey @mturoci,
Are the changes expected?
Please let me know if changes are required.
mturoci
mturoci reviewed Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the PR. I thought you tested the Linux instructions and verified they work on Windows as well.

Based on this, it also seems like your provided Windows steps will not work as they rely on relative path, not absolute.

@devarsh10
Copy link
Author

devarsh10 commented Oct 6, 2023 •
edited

Okay okay. I misunderstood.
May I close this PR then?

@mturoci
Copy link
Collaborator

mturoci commented Oct 6, 2023

Sure, np.

@devarsh10
Copy link
Author

Okay

@devarsh10 devarsh10 closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturoci mturoci mturoci left review comments

@VijithaEkanayake VijithaEkanayake Awaiting requested review from VijithaEkanayake VijithaEkanayake is a code owner

@mtanco mtanco Awaiting requested review from mtanco mtanco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devarsh10 @mturoci