introduce container type of parse_request arguments #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuho
reviewed
Feb 22, 2024
| .expect = &expect, | ||
| .digests = &stream->cache_digests, | ||
| .datagram_flow_id = NULL, | ||
| }, |
There was a problem hiding this comment.
I get the fuss, but I'm not sure if I like the direction of this PR.
As can be seen in these lines of changes, essentially this PR is changing making all arguments optional. When an argument is missing, they will be silently default-initialized (i.e., set to either 0 or NULL), rather than failing at compile time.
Is that the behavior we want? Assuming that we change the arguments rarely, my preference goes to detecting those changes as compile errors so that we can make sure we are doing the correct thing.
WDYT?
There was a problem hiding this comment.
I wonder if we could use https://gcc.gnu.org/onlinedocs/gcc-13.2.0/gcc/Warning-Options.html#index-Wmissing-field-initializers to catch this kind of errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h2o_hpack_parse_requestandh2o_qpack_parse_requesthas too many output arguments. It's especially hard to maintain since we added several fork-only arguments in our fork, and that makes the merge harder. This PR introducesh2o_hpack_request_twhich contains all of those output arguments.