Fix deprecated warn openssl 3.0 #3285
Open
+105
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request. As much I appreciate your efforts, is there a reason to stop using legacy APIs more than just suppressing the warnings? Assuming that there is not, I think we'd prefer just suppressing the warnings. I do not think we'd prefer to support two code paths (one required by OpenSSL 3.0 and above vs. another required by libressl / boringssl) just for suppressing the warnings. Once OpenSSL drops these APIs, we can adopt this PR (hence keeping it as parked). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA
For example, as far as I can tell about session ticket, apache is already fixed the deprecated warn of openssl 3.0 with EVP instead of HMAC legacy API.
https://github.com/apache/httpd/blob/8eb0f9e25331297034b590c4354c2388bf8e4f1e/modules/ssl/ssl_engine_kernel.c#L2627