Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyodide version to 0.25.0 #141

Merged
merged 15 commits into from
Mar 8, 2024
Merged

Conversation

bartbroere
Copy link
Contributor

@bartbroere bartbroere commented Apr 25, 2023

Bumping the Pyodide version. Seems to work okay, except the .isPyProxy() method now shows a deprecation warning.

TODO:

  • Iron out deprecation

@bartbroere
Copy link
Contributor Author

The monorepo approach makes it a bit hard to test this, because it really likes to use old versions from npm, instead of the version it just built.

@bartbroere
Copy link
Contributor Author

The monorepo approach makes it a bit hard to test this, because it really likes to use old versions from npm, instead of the version it just built.

I got it going by doing a yarn add ../starboard-python in the packages/starboard-notebook directory. This shows me that it works:

image

As the CI currently runs it will build each package individually but it will not test the combination of the newly built packages, since starboard-notebook gets built with the NPM release of starboard-python and starboard-rich-editor. I needed to add the artifact upload in the CI to come to that conclusion. What gives it away is that it still pulls the 0.20.0 release of Pyodide from jsdelivr.net.

This pull request is in working order though.

@bartbroere bartbroere changed the title Bump pyodide version Bump pyodide version to 0.25.0 Feb 23, 2024
@gzuidhof gzuidhof merged commit a932580 into gzuidhof:master Mar 8, 2024
3 checks passed
@gzuidhof
Copy link
Owner

gzuidhof commented Mar 8, 2024

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants