Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "more" compatibility with LESS_IS_MORE=0 #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pehjota
Copy link
Contributor

@pehjota pehjota commented Apr 20, 2024

A Debian user reported in 2007 that he has always invoked less as "more" but that the "more" compatibility mode introduced in commit 08a5ba8 didn't work for him. He requested the ability to disable it, and Debian has carried his patch ever since. This change is the same patch, forward-ported following commit 5354c92 and with a documentation update.

Example (in source tree):

$ ln -s less more
$ LESS_IS_MORE=0 ./more main.c

A Debian user reported[1] in 2007 that he has always invoked less as
"more" but that the "more" compatibility mode introduced in commit
08a5ba8 didn't work for him.  He requested the ability to disable it,
and Debian has carried his patch ever since.  This change is the same
patch, forward-ported following commit 5354c92 and with a documentation
update.

Example (in source tree):

    $ ln -s less more
    $ LESS_IS_MORE=0 ./more main.c

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=434417
@gwsw
Copy link
Owner

gwsw commented Apr 20, 2024

I'm not quite following the purpose of this. Why would someone type

$ LESS_IS_MORE=0 more main.c

rather than just

$ less main.c

?

@pehjota
Copy link
Contributor Author

pehjota commented Apr 20, 2024

I'm not quite following the purpose of this. Why would someone type

$ LESS_IS_MORE=0 more main.c

That was a contrived example to show the behavior in one command. What the user actually does is set LESS_IS_MORE=0 in his environment and then for whatever reason "typically invoke the program as 'more'". I'm not sure why he doesn't just invoke it as "less" (maybe "more" is baked into scripts, "muscle memory", etc.).

But a previous maintainer of Debian's less package accepted the user's patch, so if you don't want to support this (which I'd understand) our options in Debian are to either remove the patch (a regression for anyone relying on LESS_IS_MORE=0, so not a good option) or just keep carrying it locally (we'll have to refresh it in the next release due to commit 5354c92, but it's a tiny patch, so not a big deal). I'm mostly just trying to reduce Debian's local patches to zero (with the other PR merged, this is the last one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants