Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make rotation view customizable #308

Merged
merged 12 commits into from May 26, 2023
Merged

feat: make rotation view customizable #308

merged 12 commits into from May 26, 2023

Commits on May 22, 2023

  1. feat: update API to allow users use their own rotation control view

    @guoyingtao
    guoyingtao committed May 22, 2023
    Copy the full SHA
    1f620b1 View commit details
    Browse the repository at this point in the history

  2. refactor: refactor RotationControlViewProtocol and add comments

    @guoyingtao
    guoyingtao committed May 22, 2023
    Copy the full SHA
    d4c9436 View commit details
    Browse the repository at this point in the history

  3. refactor: use showRotationControlView instead of showRotationDial in … 

    …CropViewConfig
    @guoyingtao
    guoyingtao committed May 22, 2023
    Copy the full SHA
    7df1f1a View commit details
    Browse the repository at this point in the history

  4. fix: use RotationControlViewProtocol instead of concrete class Rotati… 

    …onDial

rename "rotation dial" with "rotation control view"
    @guoyingtao
    guoyingtao committed May 22, 2023
    Copy the full SHA
    bf4292b View commit details
    Browse the repository at this point in the history

  5. feat: add isAttachedToCropView to RotationControlViewProtocol

    @guoyingtao
    guoyingtao committed May 22, 2023
    Copy the full SHA
    2080141 View commit details
    Browse the repository at this point in the history

  6. refactor: rename showRotationControlView to showAttachedRotationContr… 

    …olView
    @guoyingtao
    guoyingtao committed May 22, 2023
    Copy the full SHA
    b104784 View commit details
    Browse the repository at this point in the history

  7. fix: fix compile errors in Example project

    @guoyingtao
    guoyingtao committed May 22, 2023
    Copy the full SHA
    e4acea2 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. feat: add more logic for rotation control view

    @guoyingtao
    guoyingtao committed May 25, 2023
    Copy the full SHA
    2291827 View commit details
    Browse the repository at this point in the history

  2. feat: move viewModel.setTouchRotationBoardStatus() to rotationControl… 

    …View.didUpdateRotationValue

to let rotation view controller which is not controlled by CropView to show rotating indicators
    @guoyingtao
    guoyingtao committed May 25, 2023
    Copy the full SHA
    55c7f10 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. fix: fix logic of setupRotationControlViewIfNeeded 

    When using rotationControlView passed by users, do not use cropViewConfig.showAttachedRotationControlView
    @guoyingtao
    guoyingtao committed May 26, 2023
    Copy the full SHA
    673bfec View commit details
    Browse the repository at this point in the history

  2. fix: fix logic in setupRotationControlViewIfNeeded and setupRotationDial

    @guoyingtao
    guoyingtao committed May 26, 2023
    Copy the full SHA
    b4b73ec View commit details
    Browse the repository at this point in the history

  3. refactor: rename setupRotationDial to setupRotationDialIfNeeded

    @guoyingtao
    guoyingtao committed May 26, 2023
    Copy the full SHA
    cecc3fe View commit details
    Browse the repository at this point in the history