chore: resolve SwiftLint errors (#304)

* Use a longer name * Disable the `large_tuple` rule * Avoid a force cast * Bind as a constant
guoyingtao · May 21, 2023 · 337a95b · 337a95b
1 parent d919e54
commit 337a95b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -1,5 +1,6 @@
 disabled_rules:
 - trailing_whitespace
+- large_tuple
 opt_in_rules:
 - empty_count
 - empty_string

diff --git a/Sources/Mantis/CropView/CropAuxiliaryIndicatorView+Accessibility.swift b/Sources/Mantis/CropView/CropAuxiliaryIndicatorView+Accessibility.swift
@@ -20,14 +20,14 @@ extension CropAuxiliaryIndicatorView {
         }
 
         accessibilityHelperViews.removeAll()
-        for i in 0..<8 {
+        for index in 0..<8 {
             let helperView = UIView(frame: .zero)
             helperView.isAccessibilityElement = true
 
             addSubview(helperView)
             accessibilityHelperViews.append(helperView)
 
-            guard let handleType = CropViewAuxiliaryIndicatorHandleType(rawValue: i + 1) else {
+            guard let handleType = CropViewAuxiliaryIndicatorHandleType(rawValue: index + 1) else {
                 continue
             }
 

diff --git a/Sources/Mantis/CropView/CropView.swift b/Sources/Mantis/CropView/CropView.swift
@@ -68,9 +68,10 @@ class CropView: UIView {
         if let indicator = cropViewConfig.cropActivityIndicator {
             activityIndicator = indicator
         } else {
-            activityIndicator = UIActivityIndicatorView(frame: .zero)
-            (activityIndicator as! UIActivityIndicatorView).color = .white
-            activityIndicator.transform = CGAffineTransform(scaleX: 2.0, y: 2.0)
+            let indicator = UIActivityIndicatorView(frame: .zero)
+            indicator.color = .white
+            indicator.transform = CGAffineTransform(scaleX: 2.0, y: 2.0)
+            activityIndicator = indicator
         }
 
         addSubview(activityIndicator)

diff --git a/Sources/Mantis/Mantis.swift b/Sources/Mantis/Mantis.swift
@@ -85,11 +85,14 @@ private(set) var bundle: Bundle? = {
 }()
 
 private func buildCropView(with image: UIImage, and cropViewConfig: CropViewConfig) -> CropViewProtocol {
+    let cropAuxiliaryIndicatorView = CropAuxiliaryIndicatorView(frame: .zero,
+                                                                cropBoxHotAreaUnit: cropViewConfig.cropBoxHotAreaUnit,
+                                                                disableCropBoxDeformation: cropViewConfig.disableCropBoxDeformation)
     let imageContainer = ImageContainer(image: image)
     let cropView = CropView(image: image,
                             cropViewConfig: cropViewConfig,
                             viewModel: buildCropViewModel(with: cropViewConfig),
-                            cropAuxiliaryIndicatorView: CropAuxiliaryIndicatorView(frame: .zero, cropBoxHotAreaUnit: cropViewConfig.cropBoxHotAreaUnit, disableCropBoxDeformation: cropViewConfig.disableCropBoxDeformation),
+                            cropAuxiliaryIndicatorView: cropAuxiliaryIndicatorView,
                             imageContainer: imageContainer,
                             cropWorkbenchView: buildCropWorkbenchView(with: cropViewConfig, and: imageContainer),
                             cropMaskViewManager: buildCropMaskViewManager(with: cropViewConfig))