Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added --use-async option: generate async handlers (tornado) #142

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ptytb
Copy link

@ptytb ptytb commented Jul 14, 2019

No description provided.

@Weilor
Copy link

Weilor commented Sep 10, 2019

The modification could not be compatible with python 2.x, though python 2.x should not be supported anymore.
Maybe we can publish a new major version to accept this pr? @rejown @zrq495 @foodszhang

@ptytb
Copy link
Author

ptytb commented Sep 10, 2019

For python prior to 3.5 (without the async keyword) it is possible to use @gen.coroutine decorator on handler methods and use yield instead of await to make them asynchronous.

So there could've been two mutually exclusive options like --use-async and --use-gen-coroutine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants