Skip to content

Commit

Permalink
chore!: Normalize repository, dropping node <10.13 support (#10)
Browse files Browse the repository at this point in the history
  • Loading branch information
sttk committed Dec 29, 2021
1 parent 8bb70b6 commit 7d54ad8
Show file tree
Hide file tree
Showing 15 changed files with 179 additions and 85 deletions.
1 change: 1 addition & 0 deletions .eslintignore
@@ -0,0 +1 @@
coverage/
75 changes: 75 additions & 0 deletions .github/workflows/dev.yml
@@ -0,0 +1,75 @@
name: dev
on:
pull_request:
push:
branches:
- master
- main
env:
CI: true

jobs:
prettier:
name: Format code
runs-on: ubuntu-latest
if: ${{ github.event_name == 'push' }}

steps:
- name: Checkout
uses: actions/checkout@v2

- name: Prettier
uses: gulpjs/prettier_action@v3.0
with:
commit_message: 'chore: Run prettier'
prettier_options: '--write .'

test:
name: Tests for Node ${{ matrix.node }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node: [10, 12, 14, 16]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
- name: Clone repository
uses: actions/checkout@v2

- name: Set Node.js version
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node }}

- run: node --version
- run: npm --version

- name: Install npm dependencies
run: npm install

- name: Run lint
run: npm run lint

- name: Run tests
run: npm test

- name: Coveralls
uses: coverallsapp/github-action@v1.1.2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: ${{matrix.os}}-node-${{ matrix.node }}
parallel: true

coveralls:
needs: test
name: Finish up

runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
uses: coverallsapp/github-action@v1.1.2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true
17 changes: 17 additions & 0 deletions .github/workflows/release.yml
@@ -0,0 +1,17 @@
name: release
on:
push:
branches:
- master
- main

jobs:
release-please:
runs-on: ubuntu-latest
steps:
- uses: GoogleCloudPlatform/release-please-action@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
release-type: node
package-name: release-please-action
bump-minor-pre-major: true
52 changes: 44 additions & 8 deletions .gitignore
@@ -1,31 +1,67 @@
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
# nyc test coverage
.nyc_output

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Compiled binary addons (http://nodejs.org/api/addons.html)
# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directory
# Commenting this out is preferred by some people, see
# https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git-
node_modules
# Dependency directories
node_modules/
jspm_packages/

# Users Environment Variables
.lock-wscript
# TypeScript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env

# next.js build output
.next

# Garbage files
.DS_Store

# Test results
test.xunit
3 changes: 0 additions & 3 deletions .jscsrc

This file was deleted.

1 change: 1 addition & 0 deletions .npmrc
@@ -0,0 +1 @@
package-lock=false
3 changes: 3 additions & 0 deletions .prettierignore
@@ -0,0 +1,3 @@
coverage/
.nyc_output/
CHANGELOG.md
11 changes: 0 additions & 11 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion LICENSE
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2015, 2017 Blaine Bublitz <blaine.bublitz@gmail.com>, Eric Schoffstall <yo@contra.io> and other contributors
Copyright (c) 2015, 2017, 2021 Blaine Bublitz <blaine.bublitz@gmail.com> and Eric Schoffstall <yo@contra.io>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
23 changes: 10 additions & 13 deletions README.md
@@ -1,12 +1,12 @@
<p align="center">
<a href="http://gulpjs.com">
<a href="https://gulpjs.com">
<img height="257" width="114" src="https://raw.githubusercontent.com/gulpjs/artwork/master/gulp-2x.png">
</a>
</p>

# undertaker-registry

[![NPM version][npm-image]][npm-url] [![Downloads][downloads-image]][npm-url] [![Build Status][travis-image]][travis-url] [![AppVeyor Build Status][appveyor-image]][appveyor-url] [![Coveralls Status][coveralls-image]][coveralls-url] [![Gitter chat][gitter-image]][gitter-url]
[![NPM version][npm-image]][npm-url] [![Downloads][downloads-image]][npm-url] [![Build Status][ci-image]][ci-url] [![Coveralls Status][coveralls-image]][coveralls-url]

Default registry in gulp 4.

Expand Down Expand Up @@ -193,18 +193,15 @@ taker.task('default', taker.series('clean', 'build', 'serve', function(cb) {

MIT

[downloads-image]: http://img.shields.io/npm/dm/undertaker-registry.svg
[npm-url]: https://npmjs.org/package/undertaker-registry
[npm-image]: http://img.shields.io/npm/v/undertaker-registry.svg

[travis-url]: https://travis-ci.org/gulpjs/undertaker-registry
[travis-image]: http://img.shields.io/travis/gulpjs/undertaker-registry.svg
<!-- prettier-ignore-start -->
[downloads-image]: https://img.shields.io/npm/dm/undertaker-registry.svg?style=flat-square
[npm-url]: https://npmjs.org/package/undertaker-registry
[npm-image]: https://img.shields.io/npm/v/undertaker-registry.svg?style=flat-square

[appveyor-url]: https://ci.appveyor.com/project/gulpjs/undertaker-registry
[appveyor-image]: https://img.shields.io/appveyor/ci/gulpjs/undertaker-registry.svg?label=appveyor
[ci-url]: https://github.com/gulpjs/undertaker-registry/actions?query=workflow:dev
[ci-image]: https://img.shields.io/github/workflow/status/gulpjs/undertaker-registry/dev?style=flat-square

[coveralls-url]: https://coveralls.io/r/gulpjs/undertaker-registry
[coveralls-image]: http://img.shields.io/coveralls/gulpjs/undertaker-registry/master.svg

[gitter-url]: https://gitter.im/gulpjs/gulp
[gitter-image]: https://badges.gitter.im/gulpjs/gulp.svg
[coveralls-image]: https://img.shields.io/coveralls/gulpjs/undertaker-registry/master.svg?style=flat-square
<!-- prettier-ignore-end -->
26 changes: 0 additions & 26 deletions appveyor.yml

This file was deleted.

1 change: 1 addition & 0 deletions index.js
Expand Up @@ -8,6 +8,7 @@ function DefaultRegistry() {
this._tasks = {};
}

/* eslint no-unused-vars: 0 */
DefaultRegistry.prototype.init = function init(taker) {};

DefaultRegistry.prototype.get = function get(name) {
Expand Down
31 changes: 18 additions & 13 deletions package.json
Expand Up @@ -9,29 +9,34 @@
"repository": "gulpjs/undertaker-registry",
"license": "MIT",
"engines": {
"node": ">= 0.10"
"node": ">= 10.13.0"
},
"main": "index.js",
"files": [
"LICENSE",
"index.js"
],
"scripts": {
"lint": "eslint . && jscs index.js test/",
"lint": "eslint .",
"pretest": "npm run lint",
"test": "mocha --async-only",
"cover": "istanbul cover _mocha --report lcovonly",
"coveralls": "npm run cover && istanbul-coveralls"
"test": "nyc mocha --async-only"
},
"devDependencies": {
"eslint": "^1.7.3",
"eslint-config-gulp": "^2.0.0",
"expect": "^1.19.0",
"istanbul": "^0.4.3",
"istanbul-coveralls": "^1.0.3",
"jscs": "^2.3.5",
"jscs-preset-gulp": "^1.0.0",
"mocha": "^3.5.0"
"eslint": "^7.32.0",
"eslint-config-gulp": "^5.0.1",
"eslint-plugin-node": "^11.1.0",
"expect": "^27.3.1",
"mocha": "^8.4.0",
"nyc": "^15.1.0"
},
"nyc": {
"reporter": [
"lcov",
"text-summary"
]
},
"prettier": {
"singleQuote": true
},
"keywords": [
"registry",
Expand Down
3 changes: 0 additions & 3 deletions test/.eslintrc

This file was deleted.

15 changes: 8 additions & 7 deletions test/index.js
Expand Up @@ -12,17 +12,18 @@ describe('undertaker-registry', function() {

it('can be constructed with new', function(done) {
var reg = new Registry();
expect(reg.get).toBeA('function');
expect(reg.set).toBeA('function');
expect(reg.tasks).toBeA('function');
expect(typeof reg.get).toEqual('function');
expect(typeof reg.set).toEqual('function');
expect(typeof reg.tasks).toEqual('function');
done();
});

it('can be constructed without new', function(done) {
/* eslint new-cap: 0 */
var reg = Registry();
expect(reg.get).toBeA('function');
expect(reg.set).toBeA('function');
expect(reg.tasks).toBeA('function');
expect(typeof reg.get).toEqual('function');
expect(typeof reg.set).toEqual('function');
expect(typeof reg.tasks).toEqual('function');
done();
});
});
Expand All @@ -31,7 +32,7 @@ describe('undertaker-registry', function() {

it('is a noop', function(done) {
var reg = new Registry();
expect(reg.init).toBeA('function');
expect(typeof reg.init).toEqual('function');
done();
});
});
Expand Down

0 comments on commit 7d54ad8

Please sign in to comment.