Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expands tilde of extends property in config file to homedir #126

Closed

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Nov 13, 2022

This PR enables to use ~ at heading of extends propery in a config file.

By this modification, users can specify a config file in each home directory of members for extends of a config file in a project directory.

@sttk sttk requested a review from phated November 13, 2022 11:55
@phated
Copy link
Member

phated commented Dec 9, 2022

@sttk do you have a use case for this?

@sttk
Copy link
Contributor Author

sttk commented Dec 11, 2022

@phated This PR is by my mistake, so I'll close this.

In the PR of gulp-cli, I changed .configFiles setting according with Liftoff v4 as follows:

var cli = new Liftoff({
  ...
  configFiles: {
    '.gulp': [
      {
        path: '.',
        extensions: interpret.extensions,
        findUp: true,
      },
      {
        path: '~',
        extensions: interpret.extensions,
      },
    ],
  },
});

and this setting loads only one config file found firstly. So I thought it was needed to use .exntends property to load one more config file in user home directory.

However, this setting is incorrect. This setting should be changed as follows:

var cli = new Liftoff({
  ...
  configFiles: {
    project: [
      {
        name: '.gulp',
        path: '.',
        extensions: interpret.extensions,
        findUp: true,
      },
    ],
    userHome: [
      {
        name: '.gulp',
        path: '~',
        extensions: interpret.extensions,
      },
    ],
  },
});

Therefore, I'll close this PR and modify the PR of gulp-cli.

@sttk sttk closed this Dec 11, 2022
@sttk sttk deleted the expands-homedir-in-extends-in-config-file branch December 13, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants