Breaking: Utilize evented-require and emit-mapper modules to remove this.requireLocal #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
refactor-preloads
branch
from
ac83f7e
to
11ee36a
Compare
|
I thought this would be easy to adapt to rechoir but I'm having some troubles with the API. I might need to think about these APIs a little more. |
|
cc @TrySound this is the big blocker but the API didn't work out |
|
Closing this, as I believe that we want to replace all/a lot of this logic with a new implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sttk this is an example of how I plan to combine
emit-mapperandevented-requireto clean up some of the implementation of this module. I also hope to expand this torechoirso we have a unified API for loading modules.