Breaking: Rename events to be more specific #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttk
approved these changes
Apr 25, 2019
| @@ -457,13 +457,13 @@ Hacker.on('beforeRequire', function (name) { | |||
| }); | |||
| ``` | |||
|
|
|||
| #### require(name, module) | |||
| #### `on('preload:success', function(name, module) {})` | |||
|
|
|||
| Emitted when a module has been pre-loaded. | |||
There was a problem hiding this comment.
Should we add a comment for this and preload:failure that these events are emitted for a module specified by opts.require?
There was a problem hiding this comment.
Maybe we should rename 'require' to 'preload'?
There was a problem hiding this comment.
@sttk on a related node, what happens with node's --require flag? Why don't we respawn if that is present? Docs: https://nodejs.org/dist/latest-v10.x/docs/api/cli.html#cli_r_require_module
There was a problem hiding this comment.
Because --require is not a v8 option but node flag. If --require flag is specified to flaggedRespawn as 3rd argument, it respawns.
sttk
approved these changes
Apr 27, 2019
| @@ -483,7 +483,39 @@ Hacker.on('requireFail', function (name, err) { | |||
| }); | |||
README.md
Outdated
|
|
||
| ```js | ||
| var Hacker = new Liftoff({name:'hacker', require:'coffee-script'}); | ||
| var Hacker = new Liftoff({name:'hacker', preload:'coffee-script'}); | ||
| Hacker.on('beforeRequire', function (name) { |
| @@ -41,12 +41,12 @@ describe('registerLoader', function() { | |||
| var extensions = { '.conf': ['xxx', loaderPath] }; | |||
|
|
|||
|
@sttk I believe I've addressed everything I missed. |
|
@phated Perfect! I think this is all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sttk While working on #103, I realized that I want to emit more events and thought it makes more sense to namespace them inside Liftoff. What do you think about these changes?