Skip to content

Commit

Permalink
update event names in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
phated committed Oct 18, 2021
1 parent ab00826 commit 99e7de3
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions test/index.js
Expand Up @@ -575,7 +575,7 @@ describe('Liftoff', function() {
],
},
});
app.on('require', function(moduleName, module) {
app.on('loader:success', function(moduleName, module) {
logRequire.push({ moduleName: moduleName, module: module });
});
app.prepare({}, function(env) {
Expand All @@ -593,8 +593,7 @@ describe('Liftoff', function() {
});
});

// TODO: whyyyyyy doesn't this work?
it.skip('should use specified loaders (.txt)', function(done) {
it('should use specified loaders (.txt)', function(done) {
var logRequire = [];

var app = new Liftoff({
Expand All @@ -607,7 +606,7 @@ describe('Liftoff', function() {
],
},
});
app.on('require', function(moduleName, module) {
app.on('loader:success', function(moduleName, module) {
logRequire.push({ moduleName: moduleName, module: module });
});
app.prepare({}, function(env) {
Expand All @@ -625,7 +624,7 @@ describe('Liftoff', function() {
});
});

it('emits requireFail but still resolves with invalid loaders', function(done) {
it('emits `loader:failure` but still resolves with invalid loaders', function(done) {
var logFailure = [];

var app = new Liftoff({
Expand All @@ -638,7 +637,7 @@ describe('Liftoff', function() {
],
},
});
app.on('requireFail', function(moduleName, error) {
app.on('loader:failure', function(moduleName, error) {
logFailure.push({ moduleName: moduleName, error: error });
});
app.prepare({}, function(env) {
Expand Down Expand Up @@ -671,10 +670,10 @@ describe('Liftoff', function() {
],
},
});
app.on('requireFail', function(moduleName, error) {
app.on('loader:failure', function(moduleName, error) {
logFailure.push({ moduleName: moduleName, error: error });
});
app.on('require', function(moduleName, module) {
app.on('loader:success', function(moduleName, module) {
logRequire.push({ moduleName: moduleName, module: module });
});
app.prepare({}, function(env) {
Expand Down

0 comments on commit 99e7de3

Please sign in to comment.