Merge pull request #328 from AviFix/Bug#327

Bug#327
guillotinaweb · Apr 9, 2020 · 3878a17 · 3878a17
2 parents 83b745c + 3354abd
commit 3878a17
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
-# 2.5.1 (2020-03-22)
+# 2.5.2 (2020-04-09)
+
+- Fix: visibleIf returns turn even if only part of the value matches the expression
+
+#2.5.1 (2020-03-22)
 
 - Allow "VisibleIf" to work with numeric values
 

diff --git a/projects/schema-form/package.json b/projects/schema-form/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ngx-schema-form",
-  "version": "2.5.1",
+  "version": "2.5.2",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/guillotinaweb/ngx-schema-form"

diff --git a/projects/schema-form/src/lib/model/formproperty.ts b/projects/schema-form/src/lib/model/formproperty.ts
@@ -249,7 +249,8 @@ export abstract class FormProperty {
           }
         }
       } else {
-        valid = isNaN(value) ? value.indexOf(expression) !== -1 : value === expression;
+        valid = !!value ? expression.toString() === value : false;
+
       }
       return valid
     } catch (error) {