Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Executing script after tunnel up #108

Open
wants to merge 16 commits into
base: development
Choose a base branch
from
Open

Executing script after tunnel up #108

wants to merge 16 commits into from

Conversation

jaype87
Copy link

@jaype87 jaype87 commented Dec 17, 2021

Resolves #88

@guillaumedsde
Copy link
Owner

thanks for the contribution, I'll look this over after the holidays

guillaumedsde
guillaumedsde suggested changes Jan 2, 2022
View reviewed changes
Copy link
Owner

@guillaumedsde guillaumedsde left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I've added a couple of minor suggestions

Some of these points will be made clearer for future contributors once I've added a proper CI to this project (curently the CI runs on gitlab its not ideal)

rootfs/usr/sbin/tunnelUp.sh Show resolved Hide resolved
rootfs/usr/sbin/tunnelUp.sh Outdated Show resolved Hide resolved
rootfs/usr/sbin/tunnelDown.sh Outdated Show resolved Hide resolved
rootfs/usr/sbin/tunnelUp.sh Outdated Show resolved Hide resolved
rootfs/usr/sbin/tunnelDown.sh Outdated Show resolved Hide resolved
rootfs/etc/services.d/qbittorrent/run Outdated Show resolved Hide resolved
rootfs/etc/services.d/qbittorrent/run Outdated Show resolved Hide resolved
rootfs/etc/services.d/qbittorrent/run Outdated Show resolved Hide resolved
jaype87 and others added 9 commits January 10, 2022 00:07
@jaype87 @guillaumedsde
Update rootfs/usr/sbin/tunnelUp.sh
393e5fe 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87 @guillaumedsde
Update rootfs/usr/sbin/tunnelUp.sh
1b81ebc 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87 @guillaumedsde
Update rootfs/usr/sbin/tunnelDown.sh
3db7408 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87 @guillaumedsde
Update rootfs/usr/sbin/tunnelDown.sh
4ee3003 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87 @guillaumedsde
Update rootfs/etc/services.d/qbittorrent/run
44a883e 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87 @guillaumedsde
Update rootfs/usr/sbin/tunnelUp.sh
60606d3 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87 @guillaumedsde
Update rootfs/etc/services.d/qbittorrent/run
121158a 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87 @guillaumedsde
Update rootfs/etc/services.d/qbittorrent/run
418b2f0 
Co-authored-by: guillaumedsde <30023543+guillaumedsde@users.noreply.github.com>
@jaype87
change scripts to use environment variables
a24c72b
@jaype87
Copy link
Author

jaype87 commented Jan 10, 2022

Made some further changes to use environment variables instead of hardcoded paths.

@guillaumedsde guillaumedsde changed the base branch from master to development March 8, 2022 20:24
@jaype87
Copy link
Author

jaype87 commented May 6, 2022

@guillaumedsde Hey, GitHub still shows as chages requested for me, but I cannot find what exactly it refers to. Can you have another look from your end?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillaumedsde guillaumedsde Awaiting requested review from guillaumedsde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[help wanted] [enhancement] - Executing script after tunnel up
2 participants
@jaype87 @guillaumedsde