Fix field usage on prepared input types #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrichardlai
force-pushed
the
fix-field-usage-on-prepared-input-types
branch
from
c63d0d6
to
2db5c92
Compare
engwan
reviewed
Mar 20, 2024
| @@ -48,7 +48,7 @@ def extract_deprecated_arguments(argument_values) | |||
| argument_type = argument_type.of_type | |||
| end | |||
|
|
|||
| if argument_type.kind.input_object? | |||
| if argument_type.kind.input_object? && argument.value.respond_to?(:arguments) # Skip if value is not a GraphQL::Schema::InputObject | |||
There was a problem hiding this comment.
We are running into the same issue with the graphql-ruby upgrade and this problem also happens below on line 60.
That is the case where the argument is a list of input objects. The call to value.arguments there fails too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This fix just prevents
FieldUsagefrom breaking when anInputTypeis preparing a value.A bug report has been submitted rmosolgo#4864