Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal notifications are broken #445

Open
n8fr8 opened this issue Mar 19, 2021 · 14 comments
Open

Signal notifications are broken #445

n8fr8 opened this issue Mar 19, 2021 · 14 comments

Comments

@n8fr8
Copy link
Member

n8fr8 commented Mar 19, 2021

Moving to WhisperSystem's lisignal library directly here:

https://github.com/guardianproject/haven/tree/libsignal-update

@n8fr8 n8fr8 changed the title Signal notifcations are broken Signal notifications are broken Mar 19, 2021
@n8fr8
Copy link
Member Author

n8fr8 commented Mar 19, 2021

@lukeswitz @archie94 if you have any interest here to pitch on this, happy to have some help!

Once we get this working, going to push out an official 0.3 beta/release.

@archie94
Copy link
Collaborator

Kindly allow me some time. Will get back on this.

@n8fr8
Copy link
Member Author

n8fr8 commented Mar 19, 2021

I've gotten pieces of it done, but need to figure out how to implement the Signal protocol store.

https://github.com/guardianproject/haven/tree/libsignal-update/src/main/java/org/havenapp/main/service/signal

@exaveal
Copy link

exaveal commented Jun 11, 2021

Lot of people waiting for having the app back online. Thx so much! Looking forward to be able to use it again!

@archie94
Copy link
Collaborator

So the library in itself seems deprecated and out of date. signalapp/libsignal-service-java#83

And its replacement seems to be embedded inside the main android app repository. One idea comes to my mind, lets see if that works for us.

@lukeswitz
Copy link
Collaborator

One idea comes to my mind, lets see if that works for us.

Thanks, I was also stuck on the legacy implementation, both ideological and technical, so I appreciate your help @archie94 🤝

@n8fr8
Copy link
Member Author

n8fr8 commented Jul 20, 2021

There is also the signald.org project, though that may be building on the out of data libsignal-service-java.

Maybe we should extract libsignal from the Signal Android repo?

@n8fr8
Copy link
Member Author

n8fr8 commented Jul 20, 2021

Actually we should use this: https://github.com/signalapp/libsignal-client

@archie94
Copy link
Collaborator

There is also the signald.org project, though that may be building on the out of data libsignal-service-java.

Maybe we should extract libsignal from the Signal Android repo?

Yeah i was thinking along similar lines ...

Actually we should use this: https://github.com/signalapp/libsignal-client

But this looks better. 👍

@closingin
Copy link

closingin commented Dec 9, 2021

Hello there !

I was looking forward to use Signal notifications, has there been any progress on this issue ?

@archie94
Copy link
Collaborator

archie94 commented Jan 1, 2022

Hello,

Exploring https://github.com/signalapp/libsignal-client but documentation is not very clear and it seems we need to implement security layers on top of the basic messaging functionality to get it working. This is significant task at the moment which will take time from my end. Will update from my side as I have anything significant.

@Gottale
Copy link

Gottale commented Mar 12, 2023

I came across this project and was reminded of the issues with haven/signal.
https://github.com/AsamK/signal-cli
Appears to be using a forked version of libsignal-service-java thats updated quite regularly.

Is this of any help?

@joeyboon
Copy link

Hi, I would just like to state that this issue still persists. Hopefully you will be able to fix this.

@lukeswitz
Copy link
Collaborator

I found a few ways to make it work. Problem is, rest of the app is in need of serious love. In communication with Google now should we want SMS as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants