Pin SASS version to reduce log noise #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>1.32, SASS spits out deprecation warnings for certain calc() functions. These warnings are from our dependency on ElasticUI, who currently have no intention to fix them - see: elastic/eui#5682 (comment). The best solution until ElasticUI have fixed these warnings is to pin our SASS version.
jonathonherbert
approved these changes
Jul 13, 2023
Fweddi
commented
Jul 13, 2023
| @@ -20,7 +20,7 @@ | |||
| "@types/react-dom": "~17.0.19", | |||
| "@vitejs/plugin-react-swc": "^3.0.0", | |||
| "jest": "^29.5.0", | |||
| "sass": "^1.60.0", | |||
| "sass": "~1.32.13", | |||
There was a problem hiding this comment.
We have tried to suppress the warnings in https://github.com/guardian/typerighter/blob/main/apps/rule-manager/client/vite.config.ts#L29-L33, but this doesn't work because of some decisions by the maintainers of SASS.
- They don't want anyone to ever be able to turn off deprecation warnings, because as soon as those features are removed from the language and go from warnings to errors, they will be flooded with GitHub issues.
- They made one exception, which is if a dependency is the cause, then you can "quiet" just those.
- But then they made it so that their definition of a "dependency" is so strict that it is unlikely anyone actually meets that criteria, so you can't actually turn off the deprecation warnings (their intended outcome).
See https://stackoverflow.com/a/75025363 for more.
There was a problem hiding this comment.
In other words: it's awful, but it's lawful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For versions >1.32, SASS spits out deprecation warnings for certain calc() functions. These warnings are from our dependency on ElasticUI, who currently have no intention to fix them - see: elastic/eui#5682 (comment).
The best solution until ElasticUI have fixed these warnings is to pin our SASS version.
I've tested locally and the application runs as expected.