Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

Add a feature to rewrite the apt sources files #22

Merged
merged 3 commits into from
May 20, 2015

Conversation

cb372
Copy link
Contributor

@cb372 cb372 commented May 19, 2015

This feature rewrites all references to Ubuntu's EC2 mirrors (e.g. eu-west-1.ec2.archive.ubuntu.com) to point to the canonical repo server (archive.ubuntu.com) instead.

This is designed to be used as a temporary workaround for when the EC2 mirrors break, which happens occasionally.

I've tested it manually by spinning up an EC2 instance using the generated AMI and running install.sh.

Chris Birchall added 2 commits May 19, 2015 18:04
This feature rewrites all references to Ubuntu's EC2 mirrors
(e.g. eu-west-1.ec2.archive.ubuntu.com) to point to the canonical repo
server (archive.ubuntu.com) instead.

This is designed to be used as a temporary workaround for when the EC2
mirrors break, which happens occasionally.
@sihil
Copy link
Contributor

sihil commented May 19, 2015

Fine - I think the build error is a transient issue related to hashicorp/packer#1539.

One question was the .gitignore change? The CA cert was a .pem at one stage and there might be other reasons to exclude it. The explicitly named one is created by packer, possibly the regex needs to be widened if packer does something else locally with multiple builders?

@cb372
Copy link
Contributor Author

cb372 commented May 20, 2015

Yes, on my machine at least, Packer generated a .pem file for each image: ec2_ubuntu-trusty-java7.pem and ec2_ubuntu-trusty-java8.pem.

I can exclude those 2 files specifically if you prefer, but I don't see why we would ever want to commit a .pem file to this repo.

@sihil
Copy link
Contributor

sihil commented May 20, 2015

There is a .crt file for the gnm-ca feature. Is actually a .pem.

Can we make it ec2_*.pem?

cb372 added a commit that referenced this pull request May 20, 2015
Add a feature to rewrite the apt sources files
@cb372 cb372 merged commit 04bca68 into master May 20, 2015
@cb372 cb372 deleted the rewrite-apt-sources-feature branch May 20, 2015 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants