Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sass-lint with stylelint #27137

Merged
merged 7 commits into from May 13, 2024
Merged

Replace sass-lint with stylelint #27137

merged 7 commits into from May 13, 2024

Conversation

georgeblahblah
Copy link
Contributor

What is the value of this and can you measure success?

sass-lint is not actively maintained and it is causing us problems with vulnerabilities. This PR replaces sass-lint with stylelint, and:

  • extends the stylelint-config-standard-scss rules
  • disables any rules which cause linting to fail. This is intended to keep the PR changes small. We can review the disabled rules, especially as many of them are autofixable

As a note, there is not a lot of overlap between sass-lint's config options and stylelint!

Disables any rules which caused linting to fail to help keep the initial
PR small.

We can revisit the rules another time, as this is intended to just
replace the unmaintained `sass-lint`.
@georgeblahblah georgeblahblah requested a review from a team as a code owner May 10, 2024 16:35
@georgeblahblah georgeblahblah added this to the Health milestone May 13, 2024
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @georgeblahblah 14 minutes and 15 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants