Add 0% server-side test to update logo for Advertising Partner
#27136
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakeii
approved these changes
May 16, 2024
mxdvl
approved these changes
May 21, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @deedeeh 12 minutes and 6 seconds ago)
|
prout-bot
added
Seen-on-ADMIN-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @deedeeh 13 minutes and 12 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Adds 0% AB test to make sure the styles are applied correctly when the new labels
Advertising partnerandExclusive advertising partnerare live.What does this change?
This PR is a necessary check to make sure the work that has been done in guardian/dotcom-rendering#11217 is working as expected when the new labels are live. Also there will be room for changes or design improvements before it's rolled out to our readers.
You need to opt in the test
/opt/in/update-logo-ad-partner. For more details check https://github.com/guardian/frontend/blob/main/docs/03-dev-howtos/01-ab-testing.md