Ensure 🚀 shows for channel launch events before piece is actually 'fully' published #101
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tually 'fully' published)
twrichards
changed the title
|
build failing owning to a devx change - https://github.com/guardian/riffraff-platform/pull/94 should fix that, once its merged I can manually kick the build for this PR and we should be green, can be approved in the meantime though based on the review on the original PR #98 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR remade/copied from #98 as I foolishly put the 🚀 emoji in the original branch name and GitHub barfed. Previous PR was tested & approved by @Fweddi
Users have noticed the 🚀 emoji (added in https://github.com//pull/53) didn't display for Channel launch events unless they were after the piece is 'fully' published - this was because the `::after` element which displays the 🚀 was bound to an element which didn't display unless the piece is overall published (which isn't the case for some channel launches, obviously). This PR just corrects that CSS selector.
It's still up for debate whether restorer should show pieces launched to just some channels more explicitly in place of the 'Published' flag.