Use new @guardian/source and @guardian/source-development-kitchen packages
#11399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +28.5 kB (+3.59%) Total Size: 823 kB
ℹ️ View Unchanged
|
sndrs
force-pushed
the
oa/sndrs/single-source-pkg
branch
from
98c34a0
to
7a0eb88
Compare
github-actions
bot
removed
the
run_chromatic
sndrs
force-pushed
the
oa/sndrs/single-source-pkg
branch
from
7a0eb88
to
1c6dd9e
Compare
github-actions
bot
removed
the
run_chromatic
sndrs
changed the title
@guardian/source and @guardian/source-development-kitchen
…ndrs/single-source-pkg # Conflicts: # apps-rendering/package.json # dotcom-rendering/src/components/Badge.tsx # dotcom-rendering/src/components/Branding.importable.tsx # dotcom-rendering/src/components/FrontSectionTitle.tsx # pnpm-lock.yaml
they've not done anything since source v3. new ones may come
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
sndrs
changed the title
@guardian/source and @guardian/source-development-kitchen@guardian/source and @guardian/source-development-kitchen packages
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
sndrs
changed the title
@guardian/source and @guardian/source-development-kitchen packages@guardian/source and @guardian/source-development-kitchen packages
JamieB-gu
approved these changes
May 23, 2024
There was a problem hiding this comment.
Looks good 👍
If I've understood correctly, these packages are functionally identical to:
source-foundationsv16source-react-componentsv25source-react-components-development-kitchenv21
So the only breaking changes are the ones that apply when going from our current versions to those versions ^?
Looking through the release notes, it sounds like the only change that affects us is the change in the value of neutral.38 1, which we use in the palette.ts file? So in a few cases, greys in our components will be slightly darker?
Footnotes
…ndrs/single-source-pkg # Conflicts: # dotcom-rendering/package.json
|
github-actions
bot
removed
the
run_chromatic
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new source packages:
@guardian/source@guardian/source-development-kitchenRemoves the old source eslint plugins: