Use DCR support header component in new TopBar #11393

cemms1 · 2024-05-08T14:02:55Z

What does this change?

Uses the DCR support header in the new TopBar component (see #11190)

In doing this, also:

Adds new Storybook stories for the SDC components (Header and SignInPromptHeader)
Adds Storybook mocks to show the standard Header and the SignInPromptHeader in the TopBar story

The TopBar component is currently behind a 0% test while it is being developed. It will be then trialled in an AB test before using permanently.

Why?

We are trialling a redesign of the site Header and moving the support messaging from the Header section to the TopBar.

By migrating the support header component from support-dotcom-components (SDC) to dotcom-rendering (DCR) #11290 we can keep using the SDC version in the existing header and rework the DCR version for the new top bar designs.

Screenshots

Note

The screenshots below do not include the new "title piece" section (reworked nav with the Guardian logo included) See #11368 for this work

LeftCol examples (1200px)


Before
After (signed out)
After (signed in)

Tablet (960px)


Before
After (signed out)
After (signed in)

Mobile Landscape (600px)


Before
After (signed out)
After (signed in)

Mobile (375px)


Before
After (signed out)
After (signed in)

Sign In Prompt (header variation for users who have contributed without registering)

github-actions · 2024-05-08T14:07:50Z

Size Change: +18.5 kB (+2.25%)

Total Size: 841 kB

Filename	Size	Change
`dotcom-rendering/dist/1006.client.web.********************.js`	3.18 kB	-279 B (-8.08%)	✅
`dotcom-rendering/dist/110.client.web.********************.js`	8.8 kB	+154 B (+1.78%)
`dotcom-rendering/dist/4464.client.web.********************.js`	0 B	-8.23 kB (removed)	🏆
`dotcom-rendering/dist/859.client.web.********************.js`	0 B	-2.54 kB (removed)	🏆
`dotcom-rendering/dist/9425.client.web.********************.js`	0 B	-3.17 kB (removed)	🏆
`dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js`	6.35 kB	+2.13 kB (+50.35%)	🆘
`dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js`	3.81 kB	+278 B (+7.88%)	🔍
`dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js`	4.14 kB	-314 B (-7.05%)	✅
`dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js`	6.48 kB	+2.12 kB (+48.75%)	🚨
`dotcom-rendering/dist/TopBar-importable.client.web.********************.js`	5.02 kB	+1.94 kB (+63.08%)	🆘
`dotcom-rendering/dist/1762.client.web.********************.js`	3.11 kB	+3.11 kB (new file)	🆕
`dotcom-rendering/dist/3787.client.web.********************.js`	5.51 kB	+5.51 kB (new file)	🆕
`dotcom-rendering/dist/5081.client.web.********************.js`	3.56 kB	+3.56 kB (new file)	🆕
`dotcom-rendering/dist/5934.client.web.********************.js`	8.25 kB	+8.25 kB (new file)	🆕
`dotcom-rendering/dist/6002.client.web.********************.js`	3.09 kB	+3.09 kB (new file)	🆕
`dotcom-rendering/dist/TopBarSupport-importable.client.web.********************.js`	2.76 kB	+2.76 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size	Change
`dotcom-rendering/dist/1045.client.web.********************.js`	12.4 kB	0 B
`dotcom-rendering/dist/1094.client.web.********************.js`	5.93 kB	0 B
`dotcom-rendering/dist/1199.client.web.********************.js`	3.87 kB	0 B
`dotcom-rendering/dist/1225.client.web.********************.js`	781 B	0 B
`dotcom-rendering/dist/1299.client.web.********************.js`	926 B	0 B
`dotcom-rendering/dist/131.client.web.********************.js`	3.46 kB	0 B
`dotcom-rendering/dist/1374.client.web.********************.js`	3.04 kB	0 B
`dotcom-rendering/dist/1568.client.web.********************.js`	18 kB	+6 B (+0.03%)
`dotcom-rendering/dist/1640.client.web.********************.js`	4.83 kB	0 B
`dotcom-rendering/dist/1821.client.web.********************.js`	3.83 kB	0 B
`dotcom-rendering/dist/1889.client.web.********************.js`	3.61 kB	0 B
`dotcom-rendering/dist/1976.client.web.********************.js`	3.03 kB	0 B
`dotcom-rendering/dist/2170.client.web.********************.js`	6.75 kB	0 B
`dotcom-rendering/dist/2193.client.web.********************.js`	3.88 kB	0 B
`dotcom-rendering/dist/226.client.web.********************.js`	3.8 kB	0 B
`dotcom-rendering/dist/2302.client.web.********************.js`	3.39 kB	0 B
`dotcom-rendering/dist/2342.client.web.********************.js`	1 kB	0 B
`dotcom-rendering/dist/2344.client.web.********************.js`	3.35 kB	0 B
`dotcom-rendering/dist/2373.client.web.********************.js`	10.3 kB	0 B
`dotcom-rendering/dist/2471.client.web.********************.js`	715 B	0 B
`dotcom-rendering/dist/2778.client.web.********************.js`	853 B	0 B
`dotcom-rendering/dist/2784.client.web.********************.js`	5.86 kB	0 B
`dotcom-rendering/dist/2792.client.web.********************.js`	6.39 kB	0 B
`dotcom-rendering/dist/2920.client.web.********************.js`	526 B	0 B
`dotcom-rendering/dist/3000.client.web.********************.js`	887 B	0 B
`dotcom-rendering/dist/3099.client.web.********************.js`	3.78 kB	0 B
`dotcom-rendering/dist/3114.client.web.********************.js`	651 B	0 B
`dotcom-rendering/dist/3118.client.web.********************.js`	496 B	0 B
`dotcom-rendering/dist/32.client.web.********************.js`	3.61 kB	0 B
`dotcom-rendering/dist/3255.client.web.********************.js`	803 B	0 B
`dotcom-rendering/dist/3336.client.web.********************.js`	781 B	0 B
`dotcom-rendering/dist/3413.client.web.********************.js`	3.57 kB	+12 B (+0.34%)
`dotcom-rendering/dist/3428.client.web.********************.js`	3.85 kB	0 B
`dotcom-rendering/dist/3494.client.web.********************.js`	823 B	0 B
`dotcom-rendering/dist/3642.client.web.********************.js`	787 B	0 B
`dotcom-rendering/dist/3922.client.web.********************.js`	724 B	0 B
`dotcom-rendering/dist/3925.client.web.********************.js`	4.78 kB	0 B
`dotcom-rendering/dist/3932.client.web.********************.js`	789 B	0 B
`dotcom-rendering/dist/4021.client.web.********************.js`	4.28 kB	0 B
`dotcom-rendering/dist/4103.client.web.********************.js`	22.4 kB	0 B
`dotcom-rendering/dist/42.client.web.********************.js`	2.92 kB	0 B
`dotcom-rendering/dist/4200.client.web.********************.js`	3.57 kB	0 B
`dotcom-rendering/dist/424.client.web.********************.js`	749 B	0 B
`dotcom-rendering/dist/4442.client.web.********************.js`	823 B	0 B
`dotcom-rendering/dist/4597.client.web.********************.js`	2.98 kB	0 B
`dotcom-rendering/dist/4666.client.web.********************.js`	9.1 kB	+17 B (+0.19%)
`dotcom-rendering/dist/4673.client.web.********************.js`	723 B	0 B
`dotcom-rendering/dist/4811.client.web.********************.js`	994 B	0 B
`dotcom-rendering/dist/4935.client.web.********************.js`	3.5 kB	0 B
`dotcom-rendering/dist/5044.client.web.********************.js`	804 B	0 B
`dotcom-rendering/dist/5055.client.web.********************.js`	2.65 kB	0 B
`dotcom-rendering/dist/5077.client.web.********************.js`	441 B	0 B
`dotcom-rendering/dist/5084.client.web.********************.js`	751 B	0 B
`dotcom-rendering/dist/5247.client.web.********************.js`	2.94 kB	0 B
`dotcom-rendering/dist/5308.client.web.********************.js`	2.7 kB	0 B
`dotcom-rendering/dist/5339.client.web.********************.js`	3.53 kB	0 B
`dotcom-rendering/dist/565.client.web.********************.js`	669 B	0 B
`dotcom-rendering/dist/5817.client.web.********************.js`	915 B	0 B
`dotcom-rendering/dist/585.client.web.********************.js`	3.01 kB	0 B
`dotcom-rendering/dist/6093.client.web.********************.js`	749 B	0 B
`dotcom-rendering/dist/6106.client.web.********************.js`	2.47 kB	0 B
`dotcom-rendering/dist/6167.client.web.********************.js`	640 B	0 B
`dotcom-rendering/dist/6351.client.web.********************.js`	5.9 kB	0 B
`dotcom-rendering/dist/6640.client.web.********************.js`	906 B	0 B
`dotcom-rendering/dist/7116.client.web.********************.js`	23 kB	0 B
`dotcom-rendering/dist/7196.client.web.********************.js`	889 B	0 B
`dotcom-rendering/dist/72.client.web.********************.js`	961 B	0 B
`dotcom-rendering/dist/7270.client.web.********************.js`	155 B	0 B
`dotcom-rendering/dist/7387.client.web.********************.js`	955 B	0 B
`dotcom-rendering/dist/7660.client.web.********************.js`	3.65 kB	0 B
`dotcom-rendering/dist/7697.client.web.********************.js`	619 B	0 B
`dotcom-rendering/dist/7723.client.web.********************.js`	921 B	0 B
`dotcom-rendering/dist/7727.client.web.********************.js`	3.34 kB	0 B
`dotcom-rendering/dist/7740.client.web.********************.js`	4.42 kB	0 B
`dotcom-rendering/dist/8134.client.web.********************.js`	595 B	0 B
`dotcom-rendering/dist/8179.client.web.********************.js`	825 B	0 B
`dotcom-rendering/dist/8239.client.web.********************.js`	3 kB	0 B
`dotcom-rendering/dist/8253.client.web.********************.js`	5.87 kB	0 B
`dotcom-rendering/dist/8279.client.web.********************.js`	42.9 kB	0 B
`dotcom-rendering/dist/8464.client.web.********************.js`	3.75 kB	0 B
`dotcom-rendering/dist/8565.client.web.********************.js`	642 B	0 B
`dotcom-rendering/dist/8677.client.web.********************.js`	2.81 kB	0 B
`dotcom-rendering/dist/8768.client.web.********************.js`	1.54 kB	+1 B (+0.06%)
`dotcom-rendering/dist/8791.client.web.********************.js`	1 kB	0 B
`dotcom-rendering/dist/889.client.web.********************.js`	854 B	0 B
`dotcom-rendering/dist/8907.client.web.********************.js`	789 B	0 B
`dotcom-rendering/dist/8953.client.web.********************.js`	8.47 kB	0 B
`dotcom-rendering/dist/9060.client.web.********************.js`	877 B	0 B
`dotcom-rendering/dist/9211.client.web.********************.js`	3.83 kB	0 B
`dotcom-rendering/dist/9225.client.web.********************.js`	582 B	0 B
`dotcom-rendering/dist/9396.client.web.********************.js`	680 B	0 B
`dotcom-rendering/dist/9430.client.web.********************.js`	508 B	0 B
`dotcom-rendering/dist/9527.client.web.********************.js`	4.11 kB	0 B
`dotcom-rendering/dist/9551.client.web.********************.js`	4.3 kB	0 B
`dotcom-rendering/dist/9604.client.web.********************.js`	530 B	0 B
`dotcom-rendering/dist/9732.client.web.********************.js`	2.91 kB	0 B
`dotcom-rendering/dist/9789.client.web.********************.js`	922 B	0 B
`dotcom-rendering/dist/9936.client.web.********************.js`	1.85 kB	0 B
`dotcom-rendering/dist/AdBlockAsk-importable.client.web.********************.js`	2.85 kB	0 B
`dotcom-rendering/dist/AdPortals-importable.client.web.********************.js`	3.76 kB	0 B
`dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js`	422 B	0 B
`dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js`	3.53 kB	0 B
`dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js`	3.62 kB	0 B
`dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js`	3.02 kB	0 B
`dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js`	2.46 kB	0 B
`dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js`	3.57 kB	0 B
`dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js`	2.01 kB	0 B
`dotcom-rendering/dist/Branding-importable.client.web.********************.js`	3.08 kB	0 B
`dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js`	36.9 kB	0 B
`dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js`	1.91 kB	0 B
`dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js`	6.74 kB	0 B
`dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js`	5.75 kB	0 B
`dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js`	6.39 kB	0 B
`dotcom-rendering/dist/Carousel-importable.client.web.********************.js`	5.7 kB	0 B
`dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js`	6.26 kB	0 B
`dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js`	537 B	0 B
`dotcom-rendering/dist/CommentCount-importable.client.web.********************.js`	3.27 kB	0 B
`dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js`	1.81 kB	0 B
`dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js`	3.08 kB	0 B
`dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js`	1.67 kB	0 B
`dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js`	3.55 kB	0 B
`dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js`	4.1 kB	0 B
`dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js`	2.01 kB	0 B
`dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js`	2.44 kB	0 B
`dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js`	5.23 kB	0 B
`dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js`	623 B	0 B
`dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js`	842 B	0 B
`dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js`	342 B	0 B
`dotcom-rendering/dist/frameworks.client.web.********************.js`	20.7 kB	0 B
`dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js`	3.65 kB	0 B
`dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js`	10.9 kB	0 B
`dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js`	2.19 kB	0 B
`dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js`	2.64 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js`	13.7 kB	0 B
`dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js`	8.55 kB	0 B
`dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js`	3.01 kB	0 B
`dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js`	7.05 kB	0 B
`dotcom-rendering/dist/index.client.web.********************.js`	46.9 kB	+74 B (+0.16%)
`dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js`	3.65 kB	0 B
`dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js`	854 B	0 B
`dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js`	7.13 kB	0 B
`dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js`	4.66 kB	0 B
`dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js`	3.47 kB	+13 B (+0.38%)
`dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js`	5.51 kB	0 B
`dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js`	3.5 kB	0 B
`dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js`	4.51 kB	0 B
`dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js`	434 B	0 B
`dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js`	6.44 kB	0 B
`dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js`	3.69 kB	+2 B (+0.05%)
`dotcom-rendering/dist/Liveness-importable.client.web.********************.js`	4.93 kB	0 B
`dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js`	5.67 kB	0 B
`dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js`	4.47 kB	0 B
`dotcom-rendering/dist/Metrics-importable.client.web.********************.js`	2.97 kB	0 B
`dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js`	4.03 kB	0 B
`dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js`	6.73 kB	0 B
`dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js`	4.88 kB	0 B
`dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js`	4.08 kB	0 B
`dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js`	3.63 kB	0 B
`dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js`	2.79 kB	0 B
`dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js`	3.03 kB	0 B
`dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js`	750 B	0 B
`dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js`	2.79 kB	0 B
`dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js`	469 B	0 B
`dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js`	1.89 kB	0 B
`dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js`	1.99 kB	0 B
`dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js`	4.62 kB	0 B
`dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js`	4.46 kB	0 B
`dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js`	4.43 kB	0 B
`dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js`	2.14 kB	0 B
`dotcom-rendering/dist/sentry.client.web.********************.js`	765 B	0 B
`dotcom-rendering/dist/SetABTests-importable.client.web.********************.js`	3.77 kB	0 B
`dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js`	484 B	0 B
`dotcom-rendering/dist/ShareButton-importable.client.web.********************.js`	1.52 kB	0 B
`dotcom-rendering/dist/shimport.client.web.********************.js`	2.79 kB	0 B
`dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js`	648 B	0 B
`dotcom-rendering/dist/ShowMore-importable.client.web.********************.js`	5.73 kB	0 B
`dotcom-rendering/dist/SignInGateCustomizableText.client.web.********************.js`	3.66 kB	0 B
`dotcom-rendering/dist/SignInGateMain.client.web.********************.js`	3.9 kB	0 B
`dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js`	3.95 kB	0 B
`dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js`	4.32 kB	0 B
`dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js`	3.94 kB	+3 B (+0.08%)
`dotcom-rendering/dist/SubNav-importable.client.web.********************.js`	3.24 kB	0 B
`dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js`	1.44 kB	0 B
`dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js`	3.23 kB	0 B
`dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js`	1.01 kB	0 B
`dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js`	3.66 kB	0 B
`dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js`	4.49 kB	0 B
`dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js`	3.49 kB	0 B
`dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js`	5.52 kB	0 B
`dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js`	3.5 kB	0 B

_{compressed-size-action}

github-actions · 2024-05-08T15:37:54Z

Deploy build 34592 of `Mobile::mobile-apps-rendering` to CODE

All deployment options

From guardian/actions-riff-raff.

github-actions · 2024-05-08T15:59:09Z

Deploy build 10486 of `dotcom:rendering-all` to CODE

All deployment options

From guardian/actions-riff-raff.

dotcom-rendering/src/components/TopBarSupport.importable.tsx

github-actions · 2024-05-17T08:40:55Z

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

github-actions bot added the dotcom-rendering label May 8, 2024

cemms1 mentioned this pull request May 8, 2024

Migrate header files from support-dotcom-components #11290

Merged

cemms1 force-pushed the cemms1/top-bar-use-dcr-support-header branch from 18bb57a to 8c4b18d Compare May 8, 2024 15:36

cemms1 force-pushed the cemms1/top-bar-use-dcr-support-header branch from 8c4b18d to e2e6282 Compare May 8, 2024 15:53

tomrf1 reviewed May 9, 2024

View reviewed changes

dotcom-rendering/src/components/TopBarSupport.importable.tsx Outdated Show resolved Hide resolved

cemms1 force-pushed the migrate-header-from-sdc branch from 3499f11 to 5fa9462 Compare May 9, 2024 10:15

cemms1 force-pushed the cemms1/top-bar-use-dcr-support-header branch from e2e6282 to c494a87 Compare May 9, 2024 16:56

cemms1 force-pushed the migrate-header-from-sdc branch from 5fa9462 to 8fb4e25 Compare May 14, 2024 10:33

cemms1 force-pushed the cemms1/top-bar-use-dcr-support-header branch from c494a87 to 2e32653 Compare May 14, 2024 16:39

Base automatically changed from migrate-header-from-sdc to main May 15, 2024 09:39

cemms1 force-pushed the cemms1/top-bar-use-dcr-support-header branch 2 times, most recently from 0b36a27 to 682287d Compare May 16, 2024 15:36

cemms1 added the run_chromatic Runs chromatic when label is applied label May 16, 2024

github-actions bot removed the run_chromatic Runs chromatic when label is applied label May 16, 2024

cemms1 added the run_chromatic Runs chromatic when label is applied label May 16, 2024

github-actions bot removed the run_chromatic Runs chromatic when label is applied label May 16, 2024

cemms1 marked this pull request as ready for review May 17, 2024 08:40

cemms1 requested review from a team as code owners May 17, 2024 08:40

cemms1 marked this pull request as draft May 17, 2024 10:40

cemms1 force-pushed the cemms1/top-bar-use-dcr-support-header branch from 2d8f9f2 to 6caf9aa Compare May 22, 2024 17:03

cemms1 added 5 commits May 23, 2024 16:19

migrate header files from support-dotcom-components

6dd4a88

remove useHasBeenSeen hook in favour of existsing useIsInView hook

2789de5

use DCR support header instead of SDC one

cf94432

use DCR version of SDC header in new TopBar component only

3ea8c69

wip designs for support messaging

1ea8979

cemms1 added 10 commits May 23, 2024 16:22

update css for support messaging

13af6ff

fix sdc storybook decorator for topbar and style signinprompt header

f109a20

Add contributions headers to top bar story

6691439

remove duplicated reduce motion css

06960a0

fix storybook mocks for support messaging in masthead component

fb05b1c

remove benefits from header args for sign in prompt

f62fdd2

change size of primary cta on mobile viewports

61e3f3b

improve header stories

9dfd95d

use grid css for styles, restyle sign in prompt version

76f8a0d

use theme palette rather than source palette in sdc migrated components

eb97c7f

cemms1 force-pushed the cemms1/top-bar-use-dcr-support-header branch from fc4a78a to eb97c7f Compare May 23, 2024 15:24

cemms1 added the run_chromatic Runs chromatic when label is applied label May 23, 2024

github-actions bot removed the run_chromatic Runs chromatic when label is applied label May 23, 2024

cemms1 marked this pull request as ready for review May 23, 2024 16:08

cemms1 requested a review from frederickobrien May 23, 2024 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use DCR support header component in new TopBar #11393

Use DCR support header component in new TopBar #11393

cemms1 commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 17, 2024

Use DCR support header component in new TopBar #11393

Are you sure you want to change the base?

Use DCR support header component in new TopBar #11393

Conversation

cemms1 commented May 8, 2024 • edited

What does this change?

Why?

Screenshots

Sign In Prompt (header variation for users who have contributed without registering)

github-actions bot commented May 8, 2024 • edited

github-actions bot commented May 8, 2024 • edited

Deploy build 34592 of Mobile::mobile-apps-rendering to CODE

github-actions bot commented May 8, 2024 • edited

Deploy build 10486 of dotcom:rendering-all to CODE

github-actions bot commented May 17, 2024

cemms1 commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

Deploy build 34592 of `Mobile::mobile-apps-rendering` to CODE

github-actions bot commented May 8, 2024 •

edited

Deploy build 10486 of `dotcom:rendering-all` to CODE