Use bundler module resolution in TSConfig #11373
Open
+101
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable the consumption of package.json#exports, which is what library authors declare as the public API and has replaced package.json#main; Update related depedencies accordingly Read more: https://www.typescriptlang.org/tsconfig/#moduleResolution Co-Authored-By: Alex Sanders <alex@sndrs.dev>
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +885 B (0%) Total Size: 785 kB
ℹ️ View Unchanged
|
mxdvl
changed the title
| @@ -0,0 +1,58 @@ | |||
| diff --git a/dist/shared/src/types/props/banner.d.ts b/dist/shared/src/types/props/banner.d.ts | |||
There was a problem hiding this comment.
just for my own understanding/curiosity: what is this file and why/how does it get generated?
There was a problem hiding this comment.
It applies a apply a pnpm patch to the dependency, which transforms it to using JSX type imports, so the tsc step is successful.
This will not be necessary if the upstream package is fixed in guardian/support-dotcom-components#1119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
moduleResolution: bundlerpnpm patchto braze-components similar to what was done for@guardian/*packagesWhy?
Enable the consumption of
package.json#exports, which is what library authors declare as the public API and has replacedpackage.json#mainKnown issues
This introduces some peer dependencies mismatch, will be be addressed in a follow-up:
$ pnpm i --resolution-only dotcom-rendering ├─┬ @guardian/braze-components 19.0.0 │ ├── ✕ unmet peer @guardian/source-react-components@^22.1.0: found 23.0.1 │ ├── ✕ unmet peer @guardian/source-react-components-development-kitchen@^19.0.0: found 20.0.1 │ └── ✕ unmet peer react@"17.0.2 || 18.2.0": found 18.3.1 ├─┬ @guardian/eslint-plugin-source-react-components 24.0.0 │ └── ✕ unmet peer @guardian/source-react-components@^22.0.1: found 23.0.1 └── …