Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint plugin for source #1440

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add eslint plugin for source #1440

wants to merge 13 commits into from

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

Why?

sndrs and others added 13 commits May 10, 2024 14:00
@sndrs @oliverabrahams
try single source package again
4ee0b26 
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
@sndrs @oliverabrahams
lint fixes
a7e2491 
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
@sndrs @oliverabrahams
include sub packages
d220c02 
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
@sndrs
standardise layout
c8360e7
@sndrs
remove accidents
4b4b651
@sndrs
make rollup config configurable
d02f8a9
@sndrs
update rollup base config
e51abb5
@sndrs
ifx config jsdoc
dc031e7
@sndrs
fix tsconfig
0b67368
@oliverabrahams @sndrs
Add storybooks to new single source package.
3d64e6e
@oliverabrahams @sndrs
Add linting fixing testing to single source package.
c1d65e2 
Co-authored-by: Alex Sanders <alex@sndrs.dev>
@oliverabrahams @sndrs
Added scripts and dependencies to single source package.
9c84458 
Co-authored-by: Alex Sanders <alex@sndrs.dev>
@oliverabrahams @sndrs
Add eslint plugin for source
5c4a577 
Co-authored-by: Alex Sanders <alex@sndrs.dev>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 10, 2024

⚠️ No Changeset found

Latest commit: 5c4a577

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 10, 2024
@sndrs sndrs force-pushed the oa/sndrs/single-source branch 2 times, most recently from 6e5e802 to e215f5b Compare May 13, 2024 11:35
Base automatically changed from oa/sndrs/single-source to main May 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oliverabrahams @sndrs