New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common Space
type across components
#1433
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: baa7406 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, does it need a patch release?
Space
type across components
Good point. I was thinking this doesn't need a release, but I suppose it does expose some new spacing values in those components. I'll add a changeset… |
fb656fa
to
0091e4b
Compare
0091e4b
to
6ded5c7
Compare
0a68247
to
fb2f807
Compare
What are you changing?
Space
type in components that accept spacing values as props.space.0
is used due to0
being falsy.Stack
stories to better show how spacing is applied.Inline
andStack
stories to include examples of all spacing values.Why?