Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance tests #652

Merged
merged 8 commits into from Oct 29, 2014
Merged

Acceptance tests #652

merged 8 commits into from Oct 29, 2014

Conversation

e2
Copy link
Contributor

@e2 e2 commented Oct 29, 2014

Finally! Guard has Cucumber/Aruba tests, so:

  • bug reports can be made "reproducable" with Cucumber scenarios
  • current specs can use mocking more aggressively (which REALLY would help with refactoring)
  • I'll stop breaking basic functionality without knowing (e.g. guard init, guard show, etc.)
  • complex/multistep scoping issues can now be reproduced!

Also, I'm using "in-process" mode of Aruba, which makes these acceptance tests really fast...

I'll add new *.features files as I go and as I discover new bugs.

Note: this also obsoletes fix #651 (since the features showed how broken 2.7 is right now...)

@thibaudgg
Copy link
Member

Awesome!

@e2
Copy link
Contributor Author

e2 commented Oct 29, 2014

Likely fixes #619, since LumberJack logging is closed/reset when CLI is done.

@e2
Copy link
Contributor Author

e2 commented Oct 29, 2014

Looks good enough for master.

e2 added a commit that referenced this pull request Oct 29, 2014
@e2 e2 merged commit d2cd5e1 into master Oct 29, 2014
@e2 e2 deleted the acceptance_tests branch October 29, 2014 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants