Show weekly slacking in reports #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
requested changes
Oct 11, 2020
| @@ -71,6 +71,9 @@ def parse_time(t): | |||
| raise ValueError('bad time: %r' % t) | |||
| hour, min = map(int, m.groups()) | |||
| return datetime.time(hour, min) | |||
|
|
|||
| def by_duration(e): | |||
| return e[1] | |||
There was a problem hiding this comment.
No, this is not generic enough to be a global function.
| @@ -656,7 +659,7 @@ def _plain_report(self, output, email, who, subject, period_name): | |||
| categories = {} | |||
| if work: | |||
| work = [(entry, duration) for start, entry, duration in work] | |||
| work.sort() | |||
| work.sort(reverse=True, key=by_duration) | |||
There was a problem hiding this comment.
This is nice, but by_duration is not useful in other contexts, so it ought to be defined here, or, even better, you can do
work = sorted(((duration, entry) for start, entry, duration in work), reverse=True)and swap entry, duration in the for loop below.
| @@ -678,6 +681,21 @@ def _plain_report(self, output, email, who, subject, period_name): | |||
| tags = self.window.set_of_all_tags() | |||
| if tags: | |||
| self._report_tags(output, tags) | |||
|
|
|||
| output.write('\nSlacking:\n\n') | |||
There was a problem hiding this comment.
Should this heading be there when there are no slack items?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be more convenient to see total slacking time and slacking time for each activity in weekly and monthly reports to analyze what activities you waste time for.