WIP: Add yearly report #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is basically a copy from the monthly report. It might make sense to present the statistics more separatedly like 0.10.3 did but it should do the trick if you just want to see the numbers.
mgedmin
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
This looks good to me!
(Or, where it doesn't look good, it's because I messed up in the past and made this kind of repetitive coding necessary.)
I'm trying to keep the test coverage at 100% (which is a big lie, because the GUI code is exempt as I'm not sure how to unit-test it), so I won't merge this as-is, but I can work on the tests myself.
|
Checklist:
|
|
Cool, thanks for picking up the work! A great feature would still be custom reports but as mentioned in an earlier ticket, yearly reports already are a nice addition for many users I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a copy from the monthly report. It might make sense to present the statistics more separatedly like 0.10.3 did but it should do the trick if you just want to see the numbers.
Tests are missing as I lack knowledge about extending these.
Documentation is also missing so far as I don't know whether this PR will be accepted,