Update master with changes in beta branch #38
Conversation
Add config functions Update code Add data attributes Update code Update custom events Update template Remove redundant code Fix show and hide dialog functionality Remove old code Revert to .mjs Update formatting Update imports Update import Remove @types/react Update dialog Update dialog Update tablist Add parameters to function Remove redundant file Fix linter error Update test Update checked state Remove whitespaces Update yarn lock Fix linting errors Remove failing test
There was a problem hiding this comment.
Ik denk het wel, maar wil wel even dubbelchecken of het klopt dat cookie-consent.mjs is verwijderd? Maar ik ken eerlijk gezegd niet alle changes in de beta branch, dus als master hierbij gewoon helemaal gelijk is aan beta dan lijkt het mij helemaal dikke prima!
@MartijnNieuwenhuizen Wil jij ook nog even kijken?
There was a problem hiding this comment.
@JairoTheDev @harmenjanssen
I think the code changes are fine if they match with the current beta.
I can imagine some additional cleanup could be nice, but that can be out of scope for this task.
What I do think should change is the Readme. This is documentation about how to use the (when this is merged) previous version) and that won't work anymore.
I think the main documentation can stay the same, just the code examples should be different. And it should mention Custom Element somewhere :)
Because this is an public repo, I think the docs should be up-to-date.
Oh, absolutely! That's a good point. @JairoTheDev Do you feel up for it? |
Nieuwe release maken van de cookie consent met de veranderingen in de
betabranch!@harmenjanssen Kan jij checken of dit klopt?